Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResolveAssemblyReference is producing 70% of node's data building Roslyn.sln #2657

Closed
Tracked by #6940
davkean opened this issue Oct 21, 2017 · 5 comments
Closed
Tracked by #6940

ResolveAssemblyReference is producing 70% of node's data building Roslyn.sln #2657

davkean opened this issue Oct 21, 2017 · 5 comments
Assignees
@AR-May
Labels
performance Performance-Scenario-Build This issue affects build performance. Priority:2 Work that is important, but not critical for the release size:1 triaged
Projects
Perf sprint Nov 8th - Nov 21st 2021
Milestone
VS 17.1

Comments

@davkean
Copy link
Member

davkean commented Oct 21, 2017

This is building commit #4b1c677e0161df22f12073a1493747532152b115 via "MSBuild.exe" Roslyn.sln /m /v:m /ds

image
@davkean
Copy link
Member Author

davkean commented Oct 21, 2017

Fixed some of it here: #2658

@AndyGerlicher AndyGerlicher added this to the MSBuild 15.6 milestone Nov 6, 2017
@panopticoncentral panopticoncentral added the Performance-Scenario-Build This issue affects build performance. label Mar 31, 2020
@panopticoncentral panopticoncentral removed this from the MSBuild 15.6 milestone May 21, 2020
@panopticoncentral panopticoncentral added the Priority:2 Work that is important, but not critical for the release label Mar 23, 2021
@rokonec
Copy link
Contributor

rokonec commented Apr 16, 2021

We are working on RAR optimization. This shall be remeasured after we are done.

@ladipro ladipro added the size:1 label Oct 12, 2021
@ladipro
Copy link
Member

ladipro commented Oct 12, 2021

Labeling with size:1 as the cost of the initial investigation. Will open a follow-up issue if more work is identified.
Note: This is an old issue, the code may have changed significantly.

@ladipro ladipro mentioned this issue Oct 12, 2021
Open
15 tasks
@AR-May AR-May self-assigned this Nov 12, 2021
@AR-May
Copy link
Member

AR-May commented Nov 19, 2021 •
edited

I built Roslyn.sln using "MSBuild.exe" Roslyn.sln /m /v:m /ds.
New versions of Roslyn and MSBuild are taken from current main branch in corresponding repos.
This does not seem to be a problem anymore:
image

@AR-May
Copy link
Member

AR-May commented Nov 19, 2021

We decided to close this issue, because 7-8% seems to be a reasonable number.
Please feel free to reopen this issue if it might still be a problem.

@AR-May AR-May closed this as completed Nov 19, 2021
@ladipro ladipro added this to the VS 17.1 milestone Dec 8, 2021
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AR-May AR-May

Labels
performance Performance-Scenario-Build This issue affects build performance. Priority:2 Work that is important, but not critical for the release size:1 triaged
Projects
Perf sprint Nov 8th - Nov 21st 2021
Done
Milestone
VS 17.1
Development

No branches or pull requests
7 participants
@panopticoncentral @davkean @benvillalobos @AndyGerlicher @ladipro @rokonec @AR-May