Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further improve CreateManifestResourceName memory allocations #5551

Closed
Tracked by #6940
benvillalobos opened this issue Jul 28, 2020 · 1 comment · Fixed by #7012
Closed
Tracked by #6940

Further improve CreateManifestResourceName memory allocations #5551

benvillalobos opened this issue Jul 28, 2020 · 1 comment · Fixed by #7012
Assignees
@ladipro
Labels
backlog help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. performance size:1 triaged
Projects
Perf sprint Oct 25th - Nov 7th 2021
Milestone
VS 17.1

Comments

@benvillalobos
Copy link
Member

This is a general issue to acknowledge that there is further work that can be done to optimize CreateManifestResourceName. It is its own issue because there's relevant conversation about it.

See the conversation at:
#5538 (comment)

Relevant issue: #5513
@benvillalobos benvillalobos added performance help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. labels Jul 28, 2020
@rainersigwald rainersigwald added this to the Backlog milestone Jul 29, 2020
@AR-May AR-May added the backlog label Apr 16, 2021
@ladipro ladipro added the size:1 label Oct 12, 2021
@ladipro
Copy link
Member

ladipro commented Oct 12, 2021

Labeling with size:1 as the cost of the initial investigation. Will open a follow-up issue if more work is identified.

@ladipro ladipro mentioned this issue Oct 12, 2021
Open
15 tasks
@ladipro ladipro self-assigned this Oct 27, 2021
@ladipro ladipro moved this from To Do to In Progress in Perf sprint Oct 25th - Nov 7th 2021 Nov 2, 2021
@ladipro ladipro mentioned this issue Nov 3, 2021
Merged
@ladipro ladipro moved this from In Progress to In Review in Perf sprint Oct 25th - Nov 7th 2021 Nov 3, 2021
@ladipro ladipro moved this from In Review to Done in Perf sprint Oct 25th - Nov 7th 2021 Nov 5, 2021
@ladipro ladipro modified the milestones: Backlog, VS 17.1 Dec 8, 2021
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ladipro ladipro

Labels
backlog help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. performance size:1 triaged
Projects
Perf sprint Oct 25th - Nov 7th 2021
Done
Milestone
VS 17.1
Development

Successfully merging a pull request may close this issue.

Use cached StringBuilder in CreateManifestResourceName ladipro/msbuild
4 participants
@rainersigwald @benvillalobos @ladipro @AR-May