Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSBuild 16.7+ No Longer Supports Legacy netcore50 Apps #5833

Closed
benvillalobos opened this issue Oct 23, 2020 · 2 comments
Closed

MSBuild 16.7+ No Longer Supports Legacy netcore50 Apps #5833

benvillalobos opened this issue Oct 23, 2020 · 2 comments

Comments

@benvillalobos
Copy link
Member

Context

Due to customers receiving bad error messages when using an older SDK and targeting net5.0, we've decided to improve this error message so that it provides a proper solution to their problem.

Old Message: The reference assemblies for {0} were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

New Message (when targeting net5.0 and on an older SDK): The reference assemblies for "{0}" were not found. You might be using an older SDK to target .NET 5.0 or higher. Update Visual Studio and/or your .NET SDK.

The Problem

Some legacy apps (UWP Windows Store 8/8.1 and potentially others) would target netcore50, not to be confused with the newer net5.0. If one happens to build one of these legacy apps on VS16.7+, they could receive the newer message which doesn't help their scenario.

The Path Forward

After discussions with @richlander , @terrajobst , and @rainersigwald , it's looking like we're okay marking this scenario as no longer supported.

This issue essentially acknowledges this as a breaking change and is meant to host the discussion for this change.

@dsplaisted
Copy link
Member

I don't believe that #5826 would change any behavior for apps targeting netcore50. I think the TargetFrameworkIdentifier for those apps would be .NETCore, and not .NETFramework or .NETCoreApp, so the new error message wouldn't kick in.

@benvillalobos
Copy link
Member Author

@dsplaisted is correct. And as @clairernovotny helped me determine, the TargetFramework is listed as ".NETCore,Version=v5.0". This can be seen via the Microsoft.AspNet.SignalR.Client package using ilspy on the binaries in the netcore50 folder.

image

So there is no breaking change after all 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants