Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Build.Framework.XamlTypes not exposed in .net core/net standard 2.0 #6045

Open
mediabuff opened this issue Jan 14, 2021 · 3 comments

Comments

@mediabuff
Copy link

Hello,
I am trying to used the types defined in Microsoft.Build.Framework.XamlTypes in a .net core or a .net standard 2.0 library. I have add ed a dependency to 'Microsoft.Build.Framework'.

These types are visibile if the consuming library is .net framework.

@drewnoakes drewnoakes transferred this issue from dotnet/project-system Jan 19, 2021
@benvillalobos
Copy link
Member

benvillalobos commented Feb 10, 2021

Team Triage: XamlTypes has not been ported to .net core yet.

<None Remove="XamlTypes\**" />
. We would be open to taking a PR for that 🙂

Note: We don't have context as to why it's specifically not being build for core flavors.

@benvillalobos benvillalobos added this to the Backlog milestone Feb 10, 2021
@benvillalobos benvillalobos added the help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. label Feb 10, 2021
@eriawan
Copy link
Member

eriawan commented Jun 10, 2021

@benvillalobos

I would like to work on this issue, but since all of those codes under XamlTypes folder needs WPF references such as System.Windows.Markup, so if we are going to include this into the netcore, we have to add <UseWPF>true</UseWPF> in the project files.

Are you ok with this?

@fearthecowboy
Copy link

Given that this would require dependency on WPF and System.Windows - is it feasible to create a Microsoft.Build.Frameworks.XamlTypes assembly?

A quick and dirty csproj file shows that it can build just fine if I take the XamlTypes folder and make a new project.

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net6.0-windows</TargetFramework>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
    <UseWPF>true</UseWPF>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.Build.Framework" Version="17.1.0" />
  </ItemGroup>

</Project>

@benvillalobos benvillalobos added the needs-attention Needs a member of the team to respond. label May 4, 2022
@rainersigwald rainersigwald added .NET Core and removed help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. needs-attention Needs a member of the team to respond. labels Aug 4, 2022
@Forgind Forgind added help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. and removed help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. labels Jun 9, 2023
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants