Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider placing ref equivalents in lib of MSBuild's nuget package #7458

Closed
benvillalobos opened this issue Mar 10, 2022 · 2 comments
Closed
Labels
Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. triaged

Comments

@benvillalobos
Copy link
Member

Issue Description

During #6148 we created a ref/ folder in MSBuild's nuget package. This caused an issue with either the sdk or nuget explained here: dotnet/sdk#24258 (comment)

Let's consider placing the equivalent ref assemblies into lib.

@benvillalobos benvillalobos added bug needs-triage Have yet to determine what bucket this goes in. labels Mar 10, 2022
@benvillalobos benvillalobos added Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. and removed bug needs-triage Have yet to determine what bucket this goes in. labels Mar 24, 2022
@Nirmal4G
Copy link
Contributor

Even with the ref Assembly, as long as lib runtime version is found, it should use it. This may be an issue with NuGet than the package itself. If we place ref within the lib, I suspect it'll break a lot of dependent projects where it'll copy Assets into some arbitrary folder for testing. Especially in cases where a flat globbing could resolve in overwriting of dlls from ref.

@rainersigwald
Copy link
Member

I don't think we're doing this so I'm going to close it.

@rainersigwald rainersigwald closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. triaged
Projects
None yet
Development

No branches or pull requests

4 participants