Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LiveLogger] Don't render any yellow or red unless/until there is a warning/error #8456

Closed
Tracked by #8370
ladipro opened this issue Feb 16, 2023 · 2 comments · Fixed by #8619
Closed
Tracked by #8370

[LiveLogger] Don't render any yellow or red unless/until there is a warning/error #8456

ladipro opened this issue Feb 16, 2023 · 2 comments · Fixed by #8619
Labels
Area: Logging Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. triaged

Comments

@ladipro
Copy link
Member

ladipro commented Feb 16, 2023

The cross mark ❌ character is usually rendered in red and it unnecessarily creates the impression that something is wrong even if the build is progressing just fine. Similar for the yellow exclamation point.

image

Suggestion: Add the <number> ℹ️, <number> ⚠️, <number> ❌ output only when <number> is >0 (for each of the three).

@ladipro ladipro added Area: Logging needs-triage Have yet to determine what bucket this goes in. Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. labels Feb 16, 2023
@rainersigwald
Copy link
Member

Strong agree on the principle "don't draw red unless there's a problem".

I'm less sure I like this display model overall--if we achieve the "warnings and errors are basically always on screen after they occur" model, we may not care about counts in the live display at all.

@edvilme
Copy link
Contributor

edvilme commented Feb 16, 2023

This could be removed entirely (and maybe replaced with "Finished without errors or warnings", or something lime that?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Logging Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. triaged
Projects
None yet
4 participants