Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Sln-based graph builds with non-built projects with solution dependencies throws #9500

Closed
dfederm opened this issue Dec 6, 2023 · 1 comment · Fixed by #9503
Closed

[Bug]: Sln-based graph builds with non-built projects with solution dependencies throws #9500

dfederm opened this issue Dec 6, 2023 · 1 comment · Fixed by #9503
Labels
backlog bug triaged

Comments

@dfederm
Copy link
Contributor

dfederm commented Dec 6, 2023

Issue Description

When doing a sln-based graph build and a project is a) not configured to build in the current configuration and b) has solution dependencies, it blows up.

Microsoft.Build.Framework.InternalErrorException: 'MSB0001: Internal MSBuild Error: nodes should include solution projects'

This is being thrown from GraphBuilder.AddEdgesFromSolution because all solutionDependencies are enumerated, even for projects which are filtered out.

Steps to Reproduce

See description

Expected Behavior

See description

Actual Behavior

See description

Analysis

No response

Versions & Configurations

No response
@dfederm dfederm added bug needs-triage Have yet to determine what bucket this goes in. labels Dec 6, 2023
@dfederm
Copy link
Contributor Author

dfederm commented Dec 6, 2023

Note: I'll be looking into this bug.

@dfederm dfederm mentioned this issue Dec 6, 2023
Merged
@AR-May AR-May added backlog and removed needs-triage Have yet to determine what bucket this goes in. labels Dec 12, 2023
@AR-May AR-May closed this as completed in f7bec32 Dec 21, 2023
@JanKrivanek JanKrivanek mentioned this issue Feb 9, 2024
Merged
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog bug triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sln-based graph builds with non-built projects with solution dependencies dfederm/msbuild
2 participants
@dfederm @AR-May