Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Standard compat: Avoid Silo being MarshalByRefObject but support running tests #2196

Closed
jdom opened this issue Sep 21, 2016 · 2 comments

Comments

@jdom
Copy link
Member

jdom commented Sep 21, 2016

In our .NET Standard solution I temporarily removed the MarshalByRefObject inheritance from the Silo class, as it's not supported in .NET Standard. See 0a80ae6 for the commit where this was excluded (ignore the test hooks for now, as this work is being done independently and is already in progress by @galvesribeiro).

Nevertheless, the testing infrastructure in the OrleansTestinhHost project (that contains TestCluster) relies on it. This project is still targeting .NET 4.6 in the vNext solution, and is able to use AppDomains, nevertheless it should not rely on the Silo class itself to be the glue between the AppDomains, and instead rely in something like AppDomainSiloHost (that can live in this test project) to inherit from MarshalByRefObject and use the Silo.

In order to open the solution that compiles using .NET Standard (and hence easy to check what is available in that environment), check out this readme

@jdom jdom added this to the CoreCLR milestone Sep 21, 2016
@jdom
Copy link
Member Author

jdom commented Sep 29, 2016

I'm grabbing this one. Will have a PR out tomorrow, but wanted to ping this issue to avoid duplicate effort.

@jdom
Copy link
Member Author

jdom commented Sep 30, 2016

Implemented in #2241

@sergeybykov sergeybykov modified the milestones: CoreCLR, 2.0.0 Nov 3, 2016
@jdom jdom closed this as completed Nov 22, 2016
@dotnet dotnet locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

2 participants