Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML Configuration Requires a Reminder Assembly when specifying a custom membership table #2527

Closed
brianqcgames opened this issue Dec 16, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@brianqcgames
Copy link

When SystemStoreType is set to "Custom" it sets both the LivenessType and the ReminderServiceType to custom. This in turn requires an assembly be specified for both the membership table and the reminder service.

I would expect that the LivenessType (and Membership) table could be specified without requiring a custom reminder service.

The exception is thrown on the following line...
if (ReminderServiceType == ReminderServiceProviderType.Custom && String.IsNullOrEmpty(ReminderTableAssembly))
throw new FormatException("ReminderTableAssembly should be set when ReminderServiceType is "Custom"");

@brianqcgames
Copy link
Author

Tagging @galvesribeiro

@galvesribeiro
Copy link
Member

AFAIK this if is not valid, at least not now. If we set the SystemStore to Custom using codeconfig and right after it we set the reminder service to disabled, this exception will not be thrown.

We should fix it.

@sergeybykov
Copy link
Contributor

Resolved via #2589.

@dotnet dotnet locked as resolved and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants