Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.Extensions.Hosting.IHostBuilder and Orleans.Hosting.ISiloHostBuilder merge #5685

Closed
lfzm opened this issue Jun 13, 2019 · 4 comments
Closed

Microsoft.Extensions.Hosting.IHostBuilder and Orleans.Hosting.ISiloHostBuilder merge #5685

lfzm opened this issue Jun 13, 2019 · 4 comments
Assignees
@ReubenBond
Labels
stale Issues with no activity for the past 6 months

Comments

@lfzm
Copy link
Contributor

lfzm commented Jun 13, 2019

Microsoft.Extensions.Hosting.IHostBuilder and Orleans.Hosting.ISiloHostBuilder now have many of the same places.
example:
Microsoft.Extensions.Hosting.HostBuilderContext and Orleans.Hosting.HostBuilderContext
Microsoft.Extensions.Hosting.IHostingEnvironment and Orleans.Hosting.IHostingEnvironment

Can these be merged or all use Microsoft.Extensions.Hosting?
@ReubenBond
Copy link
Member

Can these be merged or all use Microsoft.Extensions.Hosting?

I think we can deprecate and delete ISiloHostBuilder eventually and move everything to ISiloBuilder + HostBuilder instead. Does that sound good to you?

@ReubenBond ReubenBond self-assigned this Jun 13, 2019
@lfzm
Copy link
Contributor Author

lfzm commented Jun 13, 2019

I am looking forward to it, is there a plan?

@ReubenBond
Copy link
Member

The original plan for HostBuilder support is here: #4702 (comment)

Does that help?

@lfzm
Copy link
Contributor Author

lfzm commented Jun 13, 2019

Great, I am looking forward to it.

@lfzm lfzm closed this as completed Jun 14, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Sep 26, 2021
@ghost ghost added the stale Issues with no activity for the past 6 months label Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ReubenBond ReubenBond

Labels
stale Issues with no activity for the past 6 months
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ReubenBond @lfzm