Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is GrainCancellationToken default behivor to be called explicility? #8758

Open
dvirsegal opened this issue Dec 3, 2023 · 0 comments
Open

Comments

@dvirsegal
Copy link

I've read a lot about GrainCancellationToken and the proposed methods to improve it - see the debate on GitHub

I couldn't understand one thing; probably someone here can help clear things. I would expect a GrainCancellationToken to be similar to a CancellationToken approach for HTTP controllers, meaning if ttl is reached, implicitly cancel the request or cancel the operation.

I created a simple hello world program that tested it, registering the CancellationToken to the cancel method of GrainCancellationTokenSource, but it wasn't implicitly triggered. I had to explicitly call ThrowIfCancellationRequested

What do you think? Am I missing something?

@ghost ghost added the Needs: triage 🔍 label Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant