Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution Explorer search is not showing package contents #7834

Closed
drewnoakes opened this issue Jan 5, 2022 · 0 comments · Fixed by NuGet/NuGet.Client#4386
Closed

Solution Explorer search is not showing package contents #7834

drewnoakes opened this issue Jan 5, 2022 · 0 comments · Fixed by NuGet/NuGet.Client#4386
Assignees
Labels
Bug This is a functional issue in already written code. Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Triage-Approved Reviewed and prioritized
Milestone

Comments

@drewnoakes
Copy link
Member

Repro steps

  1. Add a NuGet package to a project
  2. Expand it to find some inner content, such as a transitively referenced project
  3. Enable "Search external items" in the Solution Explorer search box dropdown
  4. Search for package content
  5. Notice it is not displayed

For example, Shouldly version 4.0.3 shows this tree, where the highlighted region is considered "inner content":

image

Configure search:

image

Search for DiffEngine:

image

Search results should not be empty.

The search provider lives in the NuGet.Client repo, but we maintain that code so I am tracking the work item here.

https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Clients/NuGet.VisualStudio.Implementation/SolutionExplorer/AssetsFileDependenciesTreeSearchProvider.cs

@drewnoakes drewnoakes added Bug This is a functional issue in already written code. Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references labels Jan 5, 2022
@drewnoakes drewnoakes added this to the 17.1 milestone Jan 5, 2022
@drewnoakes drewnoakes self-assigned this Jan 5, 2022
@tmeschter tmeschter added the Triage-Approved Reviewed and prioritized label Jan 7, 2022
@tmeschter tmeschter modified the milestones: 17.1, 17.2 Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a functional issue in already written code. Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Triage-Approved Reviewed and prioritized
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants