Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show package .props and .targets files in Solution Explorer #7838

Closed
drewnoakes opened this issue Jan 6, 2022 · 0 comments · Fixed by NuGet/NuGet.Client#4390
Closed

Show package .props and .targets files in Solution Explorer #7838

drewnoakes opened this issue Jan 6, 2022 · 0 comments · Fixed by NuGet/NuGet.Client#4390
Assignees
Labels
Feature Request Request for a new feature, or new scenario to be handled. Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Triage-Approved Reviewed and prioritized
Milestone

Comments

@drewnoakes
Copy link
Member

drewnoakes commented Jan 6, 2022

NuGet packages can contain .props and .targets files that influence the referencing project's build in potentially surprising ways.

As part of incremental build performance investigations, we've seen package build files impacting builds in ways that break incrementality.

Such files can have a significant impact upon a project's build. Currently the fact that a package customises build is largely hidden from the user. You can find this information by drilling into the "Imports" tree, but you have to know where to look and even then you have to drill in a few levels deep.

In the following example, both the Shouldly package and the EmptyFiles package contain build customisation:

image

Making these files visible as children of package reference nodes will help expose this property of packages, where applicable.

Double-clicking such nodes should open the file in the editor in a read-only buffer.

@drewnoakes drewnoakes added Feature Request Request for a new feature, or new scenario to be handled. Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references labels Jan 6, 2022
@drewnoakes drewnoakes self-assigned this Jan 6, 2022
@drewnoakes drewnoakes added this to the 17.2 milestone Jan 6, 2022
@tmeschter tmeschter added the Triage-Approved Reviewed and prioritized label Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Request for a new feature, or new scenario to be handled. Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Triage-Approved Reviewed and prioritized
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants