Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAProject isn't MarshalByRefObject #934

Closed
bricelam opened this issue Dec 13, 2016 · 10 comments
Closed

OAProject isn't MarshalByRefObject #934

bricelam opened this issue Dec 13, 2016 · 10 comments
Labels
Area-External-CPS Owned by CPS and not this repo. Likely be closed in lieu of issue filed against VS platform.

Comments

@bricelam
Copy link

bricelam commented Dec 13, 2016

When trying to use the Entity Framework 6 PMC commands (e.g. Add-Migration) on a ASP.NET Core project targeting .NET Framework, you get the following error.

Type 'Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Package.Automation.OAProject' in assembly 'Microsoft.VisualStudio.ProjectSystem.VS.Implementation, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' is not marked as serializable.

Is there any way to make that a MarshalByRefObject like it is on the other project types?

cc @divega

@srivatsn
Copy link
Contributor

@jviau thoughts?

@davkean
Copy link
Member

davkean commented Dec 13, 2016

The other project types aren't MarshalByRef - they're native components and hence span AppDomains. :)

But I suspect as we bring up desktop compat we're going to see more and more like this, such as this: #924

@bricelam
Copy link
Author

bricelam commented Dec 13, 2016

@davkean I knew you were going to say that as I filed it. 😄 I should know better than to over-simplify on a Managed Languages repo.

@davkean
Copy link
Member

davkean commented Dec 13, 2016

:)

@jviau
Copy link
Contributor

jviau commented Dec 14, 2016

We moved CPS IVsHierarchy to COM Aggregation, but not the DTE layer. Are we wanting to start implementing MarshalByRefObject on the CPS DTE layer? That means ensuring all the objects we return are MarshalByRef, and I am not sure how deep that rabbit hole goes.

COM Aggregation / wrapping in a COM layer for the DTE feels unnecessary right now as we have no request to aggregate with anything yet.

@davkean
Copy link
Member

davkean commented Dec 14, 2016

There's no current need to aggregate it, but we may need to implement the DTE layer as marshal by ref, if we want to be a drop in replacement for the existing project system.

I've seen two different consumers so far who use us in a separate AppDomain. (TestDriven.NET) and above.

@jviau
Copy link
Contributor

jviau commented Dec 14, 2016

Okay, we will work with the EF team to find out what we all need to marshal by ref.

cc @adrianvmsft, he already prototyped this in the past

@srivatsn
Copy link
Contributor

@jviau can you close this if you're tracking this issue in your database?

@srivatsn srivatsn added the Area-External-CPS Owned by CPS and not this repo. Likely be closed in lieu of issue filed against VS platform. label Dec 21, 2016
@jviau
Copy link
Contributor

jviau commented Dec 21, 2016

@srivatsn I don't have permissions to close issues. But yes, we are tracking this in our database.

@weitzhandler
Copy link

Are we going to see any solution this any time soon?
What's the best practice of enabling migrations in the following situation without hassle?

  • VS 15.2
  • Solution consisting of (csproj):
    -- ASP.NET Web API
    -- Xamarin.Forms PCL (+Droid, iOS, UWP)

When trying to enable migrations I get the this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-External-CPS Owned by CPS and not this repo. Likely be closed in lieu of issue filed against VS platform.
Projects
None yet
Development

No branches or pull requests

5 participants