Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving a CPS multi-targeting project unglobbed net45 subtypes #997

Open
clairernovotny opened this issue Dec 19, 2016 · 3 comments
Open
Assignees
Labels
Bug This is a functional issue in already written code. Feature-Project-File-Simplification Related to cleaning up and simplification of the project format. Triage-Approved Reviewed and prioritized
Projects
Milestone

Comments

@clairernovotny
Copy link
Member

clairernovotny commented Dec 19, 2016

Look at this commit:
clairernovotny/microsoft-authentication-library-for-dotnet@f8880e6

All I did was change net45 to be first in the order but then VS expanded a bunch of crapL
clairernovotny/microsoft-authentication-library-for-dotnet@f8880e6#diff-9abb1283a16cd21deac528e4738327f7R147 by adding the <SubType>Form</SubType> elements. I don't want those in my glob.

It's worse than that too as it put those elements in a top-level item group without any conditions on it. None of the other TFM's should even see that file, that's wrong.

@davkean
Copy link
Member

davkean commented Dec 19, 2016

Not sure how this even happened, we haven't even implemented sub type support.

@davkean davkean added 0 - Backlog Bug This is a functional issue in already written code. labels Dec 19, 2016
@srivatsn srivatsn added this to the 1.0 RTM milestone Dec 20, 2016
@davkean davkean modified the milestones: 1.1, 1.0 RTM Jan 20, 2017
@srivatsn
Copy link
Contributor

srivatsn commented Apr 3, 2017

I also saw this while changing this repo to dogfood - I think this is Roslyn. Roslyn has a background analyzer which goes through all files to see if they have types with the DesignerAttribute. If they do, then it adds the SubType metadata to the file to mark it for opening with the designer on a double-click instead of opening the cs file.

That analyzer is such a drain on perf for minimal benefit. I believe @heejaechang is planning to move that analyzer out of proc but it'll be good if we can come up with some better way of representing this information. Leaving this in 15.3 to brainstorm on a path forward.

@srivatsn srivatsn modified the milestones: 15.6, 15.3 May 10, 2017
@tmeschter
Copy link
Contributor

The background analyzer for DesignerAttribute support has been disabled for CPS-based projects--the project system doesn't fully support these kinds of designers, anyway, so adding the metadata isn't really useful.

That being said, we're going to have to support them eventually, and we'll need to deal with this.

Moving out to 15.6.

@tmeschter tmeschter modified the milestones: 15.5, 15.6 Sep 27, 2017
@Pilchie Pilchie added Area-New-Project-System Feature-Project-File-Simplification Related to cleaning up and simplification of the project format. labels Dec 19, 2017
@Pilchie Pilchie modified the milestones: 15.6, Unknown Dec 19, 2017
@jjmew jjmew added the Triage-Approved Reviewed and prioritized label Jan 14, 2019
@kvenkatrajan kvenkatrajan added this to Triage - Aged - Validate in Triage Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a functional issue in already written code. Feature-Project-File-Simplification Related to cleaning up and simplification of the project format. Triage-Approved Reviewed and prioritized
Projects
No open projects
Triage
Triage - Aged - Validate
Development

No branches or pull requests

7 participants