Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching from Code Generation -> No code generation leaves an empty Update in the project file #1157

Open
davkean opened this issue Jan 13, 2017 · 1 comment
Assignees
Labels
Bug This is a functional issue in already written code. Triage-Approved Reviewed and prioritized
Projects
Milestone

Comments

@davkean
Copy link
Member

davkean commented Jan 13, 2017

In the new project system the file remains on disk, and due to the globs is part of the project:

  1. File -> New Console App (.NET Core)
  2. Right-click project, choose Add -> New Item
  3. Choose Resources file
  4. Click OK
  5. In the designer, change Access modifier from "internal" to "no code generation"

Expected:

<?xml version="1.0" encoding="utf-16"?>
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp1.0</TargetFramework>
  </PropertyGroup>
  </ItemGroup>
</Project>

Actual:

<?xml version="1.0" encoding="utf-16"?>
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp1.0</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <EmbeddedResource Update="Resource1.resx">
      <Generator>
      </Generator>
    </EmbeddedResource>
  </ItemGroup>
</Project>
@davkean davkean changed the title Switching from Code Generation -> No code generation leaves an Update in the project file Switching from Code Generation -> No code generation leaves an empty Update in the project file Jan 13, 2017
@srivatsn srivatsn added Bug This is a functional issue in already written code. and removed Bug This is a functional issue in already written code. labels Jan 18, 2017
@srivatsn srivatsn modified the milestone: 1.1 Jan 18, 2017
@srivatsn srivatsn modified the milestones: 16.0, 15.3 Apr 3, 2017
@jjmew jjmew modified the milestones: 16.0, 16.X, Backlog Jan 30, 2019
@jjmew jjmew added the Triage-Approved Reviewed and prioritized label Jan 30, 2019
@davkean
Copy link
Member Author

davkean commented Feb 1, 2020

This still occurs in 16.5.

@kvenkatrajan kvenkatrajan added this to Needs triage in Triage Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a functional issue in already written code. Triage-Approved Reviewed and prioritized
Projects
No open projects
Triage
Needs triage
Development

No branches or pull requests

3 participants