Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors about invalid references are not associated with a project #1160

Closed
davkean opened this issue Jan 13, 2017 · 9 comments
Closed

Errors about invalid references are not associated with a project #1160

davkean opened this issue Jan 13, 2017 · 9 comments
Assignees
Labels
Bug This is a functional issue in already written code.
Milestone

Comments

@davkean
Copy link
Member

davkean commented Jan 13, 2017

  1. Create a new Console App targeting .NETCoreApp1.0
  2. Create a new Console App targeting .NETCoreApp1.1
  3. Reference 2 from 1
Severity	Code	Description	Project	File	Line	Suppression State
Error		Project ConsoleApp49 is not compatible with netcoreapp1.0 (.NETCoreApp,Version=v1.0). Project ConsoleApp49 supports: netcoreapp1.1 (.NETCoreApp,Version=v1.1)			0	
Error		One or more projects are incompatible with .NETCoreApp,Version=v1.0.			0	

image

Not sure if this is our bug or SDK, but these should be associated with a project.

@davkean
Copy link
Member Author

davkean commented Jan 13, 2017

Maybe this is NuGet outputting this?

Can we stop NuGet from adding errors to the error list, and instead use our errors from Resolve the reference?

@srivatsn
Copy link
Contributor

@natidea @emgarten where did we land on who's outputting the errors for unresolved package refs?

@natidea
Copy link
Contributor

natidea commented Jan 18, 2017

I think these errors are coming from NuGet. The plan is for NuGet to add these to the assets file, and we can raise to the error list as needed.

Right now NuGet emits unresolved package refs to error list, and the SDK task adds some errors to the solution explorer where applicable (but suppresses messages to the error list for now, tracked by dotnet/sdk#585)

@davkean
Copy link
Member Author

davkean commented Jan 19, 2017

Where's the bug tracking this work?

@davkean
Copy link
Member Author

davkean commented Jan 19, 2017

The other thing I'd like to see is the errors around, references, package references and project references to be unified so that they look and feel similar. Right now it the error message for packages is really hard to parse:

Severity	Code	Description	Project	File	Line	Suppression State
Error		Package System 4.1.311.2 is not compatible with netcoreapp1.0 (.NETCoreApp,Version=v1.0). Package System 4.1.311.2 supports: net451 (.NETFramework,Version=v4.5.1)			0	

@davkean
Copy link
Member Author

davkean commented Jan 19, 2017

I also don't understand this, Dependency node makes it out to seem this is a bug:

image

Whereas, error list tells me the correct story:

Warning		Dependency specified was System (>= 1.0.0) but ended up with System 4.1.0311.2.			0	

@natidea
Copy link
Contributor

natidea commented Jan 19, 2017

The NuGet work is tracked at NuGet/Home#1599

The dependency warnings were copied from the CLI (see dotnet/sdk#26 (comment)). They may have slightly different wordings from NuGet, or I may have selected the wrong one for this scenario.

@abpiskunov
Copy link
Contributor

yes , message in the tree should be same as warning in error tree (it should come form the sdk, tree just display's it). Another thing is we need to add a correct icon for warnings instead of a question mark (that i will do)

@srivatsn srivatsn added the Bug This is a functional issue in already written code. label Jan 30, 2017
@srivatsn srivatsn added this to the 1.1 milestone Jan 30, 2017
@davkean davkean mentioned this issue May 9, 2017
7 tasks
@srivatsn
Copy link
Contributor

srivatsn commented May 9, 2017

Tracking this as part of #1660

@srivatsn srivatsn closed this as completed May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a functional issue in already written code.
Projects
None yet
Development

No branches or pull requests

4 participants