Get a not-implemented popup when you attempt to rename a resource in RESX #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #752 We were leaking NotImplementedException from ProjectItem.FileCodeModel, the legacy project system handles it this from Rosln - and returns null. Verified after this change that rename works and the dialog no longer shows.
srivatsn
approved these changes
Jan 13, 2017
|
I tested rename here as a part of this - and surprisingly it works. This just causes us to go down the same path that the legacy project system hits. |
|
tag @dotnet/project-system tag @MattGertz |
333fred
approved these changes
Jan 13, 2017
mavasani
approved these changes
Jan 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer scenario
Customers get the following dialog when attempting to add a new resource or rename a resource within the Resource Designer:
Bugs this fixes:
#752
Workarounds, if any
Click OK on the dialog.
Risk
Low
Performance impact
None
Is this a regression from a previous update?
No
Root cause analysis:
There were lots of blockers that prevented the Resource Designer from working, now that we started peeling the onion - we're finding more issues.
How was the bug found?
Ad hoc.
Dev Notes
Old legacy project system returns null when you ask for the FileCodeModel for a project item that the language service doesn't know about. We're mimic'ing this behavior.
Underneath if Roslyn returns E_NOTIMPL, it returns null. Ironically, if Roslyn just return S_OK and null, it would still work and we could the avoid the exception. I looked into that - but the Code Model lookup is pretty convoluted and used in a few places. I looked into fixing it - but would need to worry about breaking legacy project system and the VisualStudioWorkspace which has API for retrieving CodeModel items. I opt'd for a targeted fix.