Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary redirects in nuget packages for Roslyn #51

Closed
jmarolf opened this issue Dec 15, 2017 · 1 comment
Closed

Add binary redirects in nuget packages for Roslyn #51

jmarolf opened this issue Dec 15, 2017 · 1 comment

Comments

@jmarolf
Copy link
Contributor

jmarolf commented Dec 15, 2017

@jmarolf commented on Mon Jan 11 2016

See dotnet/roslyn#7654

It can be difficult to add the correct binary redirects in a console app to load a workspace and get things done in roslyn. The roslyn SDK should generate all the necessary redirects so consumers do not need to think about this,


@Pilchie commented on Mon Jan 11 2016

We should also generate the msbuild binding redirects we need for tasks that were built against MSBuild 2.0. (cc @mattwar @jasonmalinowski)


@jasonmalinowski commented on Mon Jan 11 2016

Or we should just finally implement the AppDomain, since adding stuff in the SDK doesn't help people adding Roslyn to an existing app, or upgrading their apps to newer versions of Roslyn.


@jasonmalinowski commented on Mon Jan 11 2016

Although an interesting thought: we could update our NuGet packages to include .targets which would let the MSBuild automatic app.config generation include the redirects. Was this what you were thinking of, @jmarolf?


@jmarolf commented on Mon Jan 11 2016

@jasonmalinowski Yes, we could do more in the SDK itself, but the nuget packages should know how to do this. Changing the title...

@sharwell
Copy link
Member

This is now handled by the SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants