Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCS1250 Applies collection-expression fixer when properties are set. #1399

Closed
RenderMichael opened this issue Feb 16, 2024 · 0 comments · Fixed by #1403
Closed

RCS1250 Applies collection-expression fixer when properties are set. #1399

RenderMichael opened this issue Feb 16, 2024 · 0 comments · Fixed by #1403

Comments

@RenderMichael
Copy link

Product and Version Used:

4.10.0

Steps to Reproduce:

internal sealed class EnumerableClass : IEnumerable<int>
{
    public string? Prop { get; set; }

    public IEnumerator<int> GetEnumerator() => throw new NotImplementedException();

    IEnumerator IEnumerable.GetEnumerator() => throw new NotImplementedException();
}

static EnumerableClass MakeClass()
{
    EnumerableClass x = new()
    {
        Prop = "abc", // RCS1250: Simplify object creation
    };

    return x;
}

Actual Behavior:
Apply fixer:

internal sealed class EnumerableClass : IEnumerable<int>
{
    public string? Prop { get; set; }

    public IEnumerator<int> GetEnumerator() => throw new NotImplementedException();

    IEnumerator IEnumerable.GetEnumerator() => throw new NotImplementedException();
}

static EnumerableClass MakeClass()
{
    EnumerableClass x = [
        Prop = "abc", // does not compile
    ];

    return x;
}

Expected Behavior:

Cannot simplify to a collection expression when a property is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants