Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCS1018 - Provide the ability to disable it in the options #40

Closed
Thieum opened this issue Feb 10, 2017 · 9 comments
Closed

RCS1018 - Provide the ability to disable it in the options #40

Thieum opened this issue Feb 10, 2017 · 9 comments
Assignees

Comments

@Thieum
Copy link

Thieum commented Feb 10, 2017

Using VS2015 Enterprise Update 3 / Roslynator 1.2.12 / .Net 4.6.2

Provide the ability to disable RCS1018 - Add default access modifier in the options.

rcs1018

@Thieum Thieum changed the title RCS1018 - Provide the ability to disable it RCS1018 - Provide the ability to disable it in the options Feb 10, 2017
@josefpihrt
Copy link
Collaborator

josefpihrt commented Feb 10, 2017

  • Please distinguish between analyzer and refactoring. If it has a code like "RCS...." then it is analyzer.
  • See How to Customize Analyzers.
  • Visual Studio options page works only for refactorings.

@Thieum
Copy link
Author

Thieum commented Feb 10, 2017

@josefpihrt Ah makes sense! Maybe it could help if you could add a column with the associated code in the options, as some of the refactoring share a name with analyzers.

@josefpihrt
Copy link
Collaborator

Could you be more concrete about this proposal. I'm not clear about how it should look like and what is the purpose of it. Thanks.

@Thieum
Copy link
Author

Thieum commented Mar 2, 2017

@josefpihrt I thought refactorings already had IDs, but it seems only a proposal defined in #36 .
if #36 goes ahead, I was thinking about something like this, which would self document that refactorings are a different thing than analyzer, even if they share a name:

refactorings

@josefpihrt
Copy link
Collaborator

@Thieum new options page with 'Id' column has been implemented here and here.

So I think I can close this now.

@josefpihrt josefpihrt self-assigned this Mar 13, 2017
@kieronlanning
Copy link

Perhaps I'm missing it, but where can I disable RCS1018 @josefpihrt?

The list only has RR* refactorings in it.

@josefpihrt
Copy link
Collaborator

@kieronlanning please see How to Configure Analyzers.

@kieronlanning
Copy link

Thanks @josefpihrt, I saw that after posting it. I've set it up in our 72 project solution. But we'll need to remember to add that to new each project. Is there a simpler way?

@josefpihrt
Copy link
Collaborator

Only "simpler" way I know about is to create a script that will edit csproj files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants