Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider exposing the ValidateAssemblies targets in the sdk and provide user defaults #26860

Open
ViktorHofer opened this issue Jul 28, 2022 · 1 comment

Comments

@ViktorHofer
Copy link
Member

#26616 adds the ValidateAssemblies targets which hook the ValidateAssemblies task onto a project's build. These targets are currently only included in the transport package and aren't exposed via the SDK. We should consider exposing them which will require eliminating a few assumption and provide good defaults.

The ValidateAssemblies task currently relies on providing a set of left assemblies and right assemblies. We should see if we can leverage NuGet's apis to calculate matching tuples similar to how PackageValidation works today.

We might also want to provide a default transformation pattern that avoids the rooted full paths (i.e. C:\git\runtime\artifacts\bin\...\System.Text.Json.dll). To not depend on assumptions about how the a project's output path is constructed, we could just subtract the BaseOutputPath from the full path but with the caveat that other information like the Configuration is still encoded in the transformed path.

@ViktorHofer ViktorHofer added this to the 8.0.1xx milestone Jul 28, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Jul 28, 2022
@ghost
Copy link

ghost commented Jul 28, 2022

@dotnet/area-infrastructure-libraries a new issue has been filed in the Compatibility area, please triage

@ViktorHofer ViktorHofer modified the milestones: 8.0.1xx, Backlog Aug 18, 2022
@smasher164 smasher164 modified the milestones: Backlog, 8.0.1xx Oct 19, 2022
@smasher164 smasher164 removed the untriaged Request triage from a team member label Oct 19, 2022
@ViktorHofer ViktorHofer modified the milestones: 8.0.1xx, Backlog Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants