Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container tests need a better way of using earlier Runtime versions #32099

Open
baronfel opened this issue Apr 27, 2023 · 2 comments
Open

Container tests need a better way of using earlier Runtime versions #32099

baronfel opened this issue Apr 27, 2023 · 2 comments
Labels
Area-Containers Related to dotnet SDK containers functionality

Comments

@baronfel
Copy link
Member

baronfel commented Apr 27, 2023

Echoing this - the container tests are in kind of an odd space (at least for the preview timeframe). The SDK version being used to build containers carries along a certain RuntimeFrameworkVersion implicitly, but the containers made available on mcr.microsoft.com lag behind in terms of the runtimes installed on them (by design - they are only made in the run-ups to each preview release) and so in the SDK we tend to make framework-dependent apps that we actually can't run in containers. We (containers team) need a better strategy for this and so I added these properties to 'pin' the runtimes for projects targeting net8.0 as a temporary measure.

Originally posted by @baronfel in #30038 (comment)

We (@dotnet/sdk-container-builds-maintainers) need some kind of testing strategy that is resilient to this timing issue.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NetSDK untriaged Request triage from a team member labels Apr 27, 2023
@baronfel baronfel added Area-Containers Related to dotnet SDK containers functionality and removed untriaged Request triage from a team member Area-NetSDK labels Apr 27, 2023
@tmds
Copy link
Member

tmds commented Aug 29, 2023

I assumed this might be possible using RuntimeFrameworkVersion by setting it to a floating version, but no:

sdk/8.0.100-rc.2.23428.8/NuGet.targets(156,5): error : '[8.0.*-*]' is not a valid version string.

@tmds
Copy link
Member

tmds commented Aug 29, 2023

Some things which are possible:

<TargetFramework>net8.0</TargetFramework>
<RuntimeFrameworkVersion>8.0.0-preview1</RuntimeFrameworkVersion>

or

<TargetFramework>net8.0</TargetFramework>
<RuntimeFrameworkVersion>6.0.0</RuntimeFrameworkVersion>
<RollForward>Major</RollForward>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Containers Related to dotnet SDK containers functionality
Projects
None yet
Development

No branches or pull requests

2 participants