Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable CanSortByDownloadCountAndThenByName Template Engine test #39772

Open
baronfel opened this issue Mar 26, 2024 · 2 comments
Open

Re-enable CanSortByDownloadCountAndThenByName Template Engine test #39772

baronfel opened this issue Mar 26, 2024 · 2 comments
Labels
type-investigation untriaged Request triage from a team member

Comments

@baronfel
Copy link
Member

We skipped it to unblock pipelines, but we need to figure out what changed. The output of the search cache could have changed (likely?), or the processing of the CLI output inside the test.

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Mar 26, 2024
@lewing
Copy link
Member

lewing commented Mar 26, 2024

Looking at the history it appears the name comparer used in the test was changed a few days ago but the name by name assertion doesn't use the same ellipsis logic to handle shortened names.
Strings differ\r\n ↓ (pos 0)\r\nExpected: "scottgeek.conso..."\r\nActual: "ScottGeek.Console"\r\n ↑ (pos 0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-investigation untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

2 participants