Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make depth buffer bits configurable #101

Closed
Pyrdacor opened this issue Jan 7, 2020 · 5 comments
Closed

Make depth buffer bits configurable #101

Pyrdacor opened this issue Jan 7, 2020 · 5 comments
Labels
area-Windowing enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Pyrdacor
Copy link
Contributor

Pyrdacor commented Jan 7, 2020

For my current game I need a depth buffer of at least 24 bits and need to enforce this on window creation. At the moment the glfw depth buffer bit hint is not called at all. Please add the depth buffer bit option to WindowOptions and call the associated glfw hint method. The default value may be GLFW_DONT_CARE to keep compatibility.

@Pyrdacor Pyrdacor added the enhancement New feature or request label Jan 7, 2020
@Perksey
Copy link
Member

Perksey commented Jan 7, 2020

This one will have to be done by the community. Please propose a PR adding the following APIs;

New Struct VideoMode

  • Get-only properties for the bit depths, refresh rate, and resolution (Size)

IMonitor (and GlfwMonitor)

  • Get-only property for the video mode

IViewProperties (and its inheritors)

  • Get/set VideoMode property

@Perksey Perksey added area-Windowing good first issue Good for newcomers help wanted Extra attention is needed labels Jan 7, 2020
@Pyrdacor
Copy link
Contributor Author

Pyrdacor commented Jan 7, 2020

I noticed that the depth buffer bits are not part of the video mode nor monitor in glfw. Moreover it is only a soft constraint. Should I add the VideoMode stuff for resolution and refresh rate and support specifying the depth buffer bits only on windows creation?

@Perksey
Copy link
Member

Perksey commented Jan 7, 2020

Oh I just realized you should be working on the views branch as my PR has not been merged yet. Here there are already monitor APIs to some extent, but they currently do not have the bit depth properties

@Perksey
Copy link
Member

Perksey commented Jan 7, 2020

Also change the VideoMode property to get in IViewOptions and get set in ViewOptions and WindowOptions

@Perksey
Copy link
Member

Perksey commented Jan 15, 2020

Resolved in #102.

@Perksey Perksey closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Windowing enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants