-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ArPow] Onboard linker to arcade-powered source-build #2043
Comments
PR was merged; can someone please look over the internal build to make sure things are okay? |
I took a look at the internal build and noted the following:
Update: Per #2085, we do not want to reference source-build-reference-packages
5.0 artifacts
6.0 ArPow artifacts
|
There's something strange about
So the
The
It seems like we would break the SDK build if we were to remove this and disallow prebuilts. |
Comparing with 5.0 sdk, the 5.0 SDK doesn't include illink.roslynanalyzers:
The analyzer was a recent addition, post 5.0: dotnet/linker#1563 |
Thanks @omajid, That explains the Microsoft.NET.ILLink.Analyzers package. What about the Microsoft.NET.ILLink package? I'm not seeing an SDK reference? |
That one just contains
Do you think it's worth removing it? |
Sorry, I should have cracked it open. It is curious though why this was excluded in past releases of source-build. If it is discovered to present a problem down the road, we can address it them. It would be better to avoid source-build "specializations" if not needed. Closing. |
Thanks for making me double check things! |
No description provided.
The text was updated successfully, but these errors were encountered: