Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to Pull Request Creation/Update in CreateBaselineUpdatePR Tool #41160

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented May 24, 2024

Fixes dotnet/source-build#4428

The changes in this PR introduce fixes and updates to the pull request creation/update portion of the CreateBaselineUpdatePR tool. The main differences introduced in this PR are:

  1. Added functionality to pull in the most recent updates from the target branch into the pull request
  2. The separation of logic in the CreateOrUpdatePullRequestAsync function into multiple smaller helper functions
  3. Conditionally updating the PR based on if any differences are present

@ellahathaway ellahathaway marked this pull request as ready for review May 24, 2024 22:34
@ellahathaway ellahathaway requested review from a team as code owners May 24, 2024 22:34
@ellahathaway
Copy link
Member Author

ellahathaway commented Jun 13, 2024

@dotnet/source-build-internal - Soft ping. Can I get a review on this whenever someone has a chance. Thanks!

@ellahathaway ellahathaway enabled auto-merge (squash) June 13, 2024 18:20
@ellahathaway ellahathaway merged commit ba84693 into dotnet:main Jun 13, 2024
36 checks passed
@ellahathaway ellahathaway deleted the pr-fix branch June 13, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateBaselineUpdatePR tool should merge in latest
2 participants