Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISymUnmanagedReader4.GetSourceServerData doesn't work with multipart sourcelink streams #278

Open
pharring opened this issue Mar 10, 2023 · 3 comments

Comments

@pharring
Copy link

The implementation of GetSourceServerData calls into Microsoft.DiaSymReader.Native.*
That code checks only the "sourcelink" stream. That's good enough for managed binaries.
However, it doesn't check multi-part streams emitted by the C++ tooling.
These streams are named "sourcelink$1", "sourcelink$2", etc.
For an example of how to do it right, see this code in PerfView: https://github.com/microsoft/perfview/blob/main/src/TraceEvent/Symbols/NativeSymbolModule.cs#L1136

@pharring
Copy link
Author

@JamesMcNellis FYI

@JamesMcNellis
Copy link

Hi @pharring. Thanks for the ping, but I regret to inform you I left Microsoft last summer. I'd suggest reaching out to the Visual C++ team internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants