Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect <NoWarn> in .csproj #1399

Closed
anfomin opened this issue Apr 18, 2017 · 3 comments
Closed

Respect <NoWarn> in .csproj #1399

anfomin opened this issue Apr 18, 2017 · 3 comments

Comments

@anfomin
Copy link

anfomin commented Apr 18, 2017

Environment data

dotnet --info output:

.NET Command Line Tools (1.0.1)

Product Information:
 Version:            1.0.1
 Commit SHA-1 hash:  005db40cd1

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.12
 OS Platform: Darwin
 RID:         osx.10.11-x64
 Base Path:   /usr/local/share/dotnet/sdk/1.0.1

VS Code version: 1.11.2
C# Extension version: 1.9.0-beta3

Steps to reproduce

Create project with single class. In .csproj add line:

<NoWarn>$(NoWarn);CS1591;CS1573</NoWarn>

Expected behavior

There should be no warnings in "Problems" output.

Actual behavior

2017-04-18 18 01 08

@anfomin
Copy link
Author

anfomin commented Apr 18, 2017

This issue was fixed for project.json (OmniSharp/omnisharp-roslyn#734), but new .csproj still does not respect nowarn.

@DustinCampbell
Copy link
Member

OmniSharp does support NoWarn for csproj, it's just a little finicky about it. Don't include the "CS" -- just the raw numbers.

<NoWarn>$(NoWarn);1591;1573</NoWarn>

I've filed OmniSharp/omnisharp-roslyn#826 to improve the support here. Thanks!

@anfomin
Copy link
Author

anfomin commented Apr 18, 2017

@DustinCampbell thank you! It works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants