Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension should consider using vscode.open for browser launch #2657

Closed
auchenberg opened this issue Nov 5, 2018 · 2 comments
Closed

Extension should consider using vscode.open for browser launch #2657

auchenberg opened this issue Nov 5, 2018 · 2 comments

Comments

@auchenberg
Copy link

Hi Kenneth from the VS Code team here,

We noticed the launchBrowser attribute in the launch.json as this extension has it's own logic to launch browsers.

For future scenarios we recommend using the VS Code API vscode.open that can open a URL in the browser. It works on all platforms, so when the C# extension can invoke this command, then this should work.

@gregg-miskelly
Copy link
Contributor

gregg-miskelly commented Nov 5, 2018

@auchenberg We launch the browser from the debugger, where we have no access to any VS Code API. To do this we will need a new debug protocol message for a debug adapter to request a browser to be opened.

CC @weinand @isidorn @egamma

@gregg-miskelly
Copy link
Contributor

This issue is no longer needed. Support for this is handled by serverReadyAction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants