Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Streamline application configuration and bootstrap #4909

Closed
RussKie opened this issue May 14, 2021 · 12 comments · Fixed by #5035
Closed

[Proposal] Streamline application configuration and bootstrap #4909

RussKie opened this issue May 14, 2021 · 12 comments · Fixed by #5035
Assignees
Labels
api-suggestion (1) Early API idea and discussion, it is NOT ready for implementation area-VSDesigner Windows Forms out-of-proc designer related issues enhancement Product code improvement that does NOT require public API changes/additions

Comments

@RussKie
Copy link
Member

RussKie commented May 14, 2021

Moved to dotnet/designs#223

@RussKie RussKie added enhancement Product code improvement that does NOT require public API changes/additions api-suggestion (1) Early API idea and discussion, it is NOT ready for implementation area-VSDesigner Windows Forms out-of-proc designer related issues labels May 14, 2021
@RussKie RussKie added this to the 6.0 milestone May 14, 2021
@RussKie RussKie self-assigned this May 14, 2021
@RussKie RussKie pinned this issue May 15, 2021
@RussKie
Copy link
Member Author

RussKie commented May 19, 2021

Updated dpi resolution algorithm.

@RussKie
Copy link
Member Author

RussKie commented May 27, 2021

Progress update:
projectconfiguration

@omariom
Copy link

omariom commented May 27, 2021

If the WinForms related properties were prefixed with "WinForms." it would be easier to differentiate them from others
msbuild properties.
Like

  <PropertyGroup>
    <WinForms.ApplicationManifest>app1.manifest</WinForms.ApplicationManifest>
    <WinForms.ApplicationVisualStyles>true</WinForms.ApplicationVisualStyles>
    <WinForms.ApplicationFontName>Control.DefaultFont</WinForms.ApplicationFontName>
    <WinForms.ApplicationFontSize>9</WinForms.ApplicationFontSize>
    <WinForms.ApplicationHighDpiMode>PerMonitorV2</WinForms.ApplicationHighDpiMode>
  </PropertyGroup>

@jnm2

This comment has been minimized.

@jnm2
Copy link
Contributor

jnm2 commented May 27, 2021

@omariom I've also seen people make their tooling consume XML property content similar to this:

​  <PropertyGroup>
    <WinForms>
      <ApplicationManifest>app1.manifest</ApplicationManifest>
      <ApplicationVisualStyles>true</ApplicationVisualStyles>
      <ApplicationFontName>Control.DefaultFont<ApplicationFontName>
      <ApplicationFontSize>9<ApplicationFontSize>
      <ApplicationHighDpiMode>PerMonitorV2</ApplicationHighDpiMode>
    </WinForms>
  </PropertyGroup>

@RussKie

This comment has been minimized.

@RussKie
Copy link
Member Author

RussKie commented May 27, 2021

If the WinForms related properties were prefixed with "WinForms." it would be easier to differentiate them from others
msbuild properties.

There are other existing "Application*" properties (e.g. ApplicationIcon and ApplicationManifest, and the new properties will align with those.

@kirsan31
Copy link
Contributor

#4978 triggers me: do we need ApplicationFontStyle here too?

@RussKie
Copy link
Member Author

RussKie commented May 28, 2021

#4978 triggers me: do we need ApplicationFontStyle here too?

In my opinion this starts encroaching into theming/styling territory. AFAIK Windows has never had a default font that was italic or bold.
SetDefaultFont API was added in response to the changes of the hardcoded default font, and only for the purpose of unblocking and enabling migrations of .NET Framework apps with pixel-perfect layouts. Our goal is to allow building Windows native apps, and whilst the API can now be used beyond the intended use case allowing making Windows apps that don't look native on Windows (and that includes italic or bold fonts) starts working against that goal.
To me personally allowing to make an application default font is a feature request, which probably/arguably has no valid use case behind it.

Happy to continue this discussion.

@ghost ghost added the 🚧 work in progress Work that is current in progress label Jun 3, 2021
@ghost ghost removed this from the 6.0 milestone Jul 29, 2021
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Jul 29, 2021
@dreddy-work dreddy-work unpinned this issue Aug 4, 2021
@Amy-Li03 Amy-Li03 added this to the 6.0 rc2 milestone Aug 27, 2021
@Amy-Li03
Copy link
Contributor

This issue is still reproducing on .NET 6.0 latest build: 6.0.100-rc.1.21424.1, as discussed in #5071, need other change merged into, so move Milestone to 6.0 RC2.

@Philip-Wang01
Copy link

Verified this issue with .NET 6.0 RC2 latest build: 6.0.10-rc.2.21429.3, Streamline application configuration and bootstrap have been implemented

@Amy-Li03
Copy link
Contributor

Amy-Li03 commented Sep 6, 2021

Verified this issue with TP build: 6.0.100-rc.1.21453.13, this issue has been fixed.

@Amy-Li03 Amy-Li03 modified the milestones: 6.0 rc2, 6.0 rc1 Sep 22, 2021
@dotnet dotnet locked as resolved and limited conversation to collaborators Jan 28, 2022
@RussKie RussKie removed this from the 6.0 rc1 milestone May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-suggestion (1) Early API idea and discussion, it is NOT ready for implementation area-VSDesigner Windows Forms out-of-proc designer related issues enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants