Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] LinkLabel's color contrast is less than 4.5:1 when clicking it #7726

Closed
Olina-Zhang opened this issue Sep 2, 2022 · 7 comments
Labels
tenet-accessibility MAS violation, UIA issue; problems with accessibility standards

Comments

@Olina-Zhang
Copy link
Member

.NET version

8.0.100-alpha.1.22451.15

Did it work in .NET Framework?

No

Did it work in any of the earlier releases of .NET Core or .NET 5+?

No

Issue description

LinkLabel's color contrast is less than 4.5:1 when clicking it on Win10 and Win11 default themes and high contrast themes

Win10 and Win11 default themes:
image

Win11 high contrast themes:
image

Win10 high contrast themes:
image

Steps to reproduce

Sample application:
WinFormsApp11.zip

@Olina-Zhang Olina-Zhang added untriaged The team needs to look at this issue in the next triage tenet-accessibility MAS violation, UIA issue; problems with accessibility standards labels Sep 2, 2022
@merriemcgaw

This comment was marked as outdated.

@merriemcgaw merriemcgaw removed the untriaged The team needs to look at this issue in the next triage label Sep 7, 2022
@merriemcgaw merriemcgaw added this to the .NET 8.0 milestone Sep 7, 2022
@merriemcgaw
Copy link
Member

merriemcgaw commented Sep 7, 2022

@dmitrii-drobotov / @vladimir-krestov which System Color are we using for the visited LinkLabel control?

@dmitrii-drobotov
Copy link
Contributor

dmitrii-drobotov commented Sep 8, 2022

@merriemcgaw In this issue it's actually not the visited link color (that one is violet and has good contrast ratio) but rather the active link color, i.e. the one that is visible when you click on a link but not release it yet. For that we are trying to get IE's "Anchor Color Hover" from the registry. But on my machine (Win 11) it was not found, so in that case we default to System.Drawing.Color.Red which is simple #FF0000. It also doesn't depend on whether it's a HC theme or not, so it's always red.
On screenshots from the description AI shows a little different color I think due to subpixel rendering for small fonts. If I use a bigger font to make sure text has a solid color it shows #FF0000.
image

@merriemcgaw
Copy link
Member

Ahhh, that makes a lot of sense. I think that the priority of this is much lower if it is only while the user is clicking on the link. If the Visited and not-yet-visited link colors are good, I think we can close this as won't fix. @Tanya-Solyanik do you agree?

@vladimir-krestov
Copy link
Contributor

I think, we can close this issue until a user request, because not-visited and visited states are long and users see them long time. But in most common cases clicking on the link process is so fast, so users may not notice that the color has changed to red at all.
Moreover this one-second state of link doesn't block users, they see clear what they will click and what they already clicked, they won't try to read what they are clicking in the moment, it looks like just an indicator of changing, in my opinion.
We can change the color but we will change that users used to see.
Thoughts?

@dmitrii-drobotov
Copy link
Contributor

I do have a little concern though, we adapt to HC theme colors when it comes to visited and not-visited links:
image
image
image

But the active color is always red. Users can also change link color in theme settings, and if they set it to red then active state will be unnoticeable. But I'm not sure if it's something worth changing since it indeed shows up only for a split second.

@merriemcgaw
Copy link
Member

I agree, not worth changing at this point.

@merriemcgaw merriemcgaw closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2022
@ghost ghost removed this from the .NET 8.0 milestone Sep 14, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tenet-accessibility MAS violation, UIA issue; problems with accessibility standards
Projects
None yet
Development

No branches or pull requests

4 participants