Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1629 code fix eats ending semicolon of XML entity #3802

Closed
RenderMichael opened this issue Feb 12, 2024 · 0 comments · Fixed by #3859
Closed

SA1629 code fix eats ending semicolon of XML entity #3802

RenderMichael opened this issue Feb 12, 2024 · 0 comments · Fixed by #3859

Comments

@RenderMichael
Copy link

/// <summary>
/// Indicates that this property is a dictionary containing SAML attribute values.
/// </summary>
/// <remarks>This attribute should only be placed on a Dictionary&lt;string, string?&gt;</remarks>
[AttributeUsage(AttributeTargets.Property)]
public sealed class SamlAttributesAttribute : System.Attribute;

The fixer for SA1629 will replace the ; with . instead of appending it, thereby breaking the XML syntax.

@sharwell sharwell changed the title SA1629 eats ending semicolon SA1629 code fix eats ending semicolon of XML entity Feb 13, 2024
bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Jun 6, 2024
…tity. Previously replaced the semicolon in the xml entity. DotNetAnalyzers#3802
bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Jun 6, 2024
…tity. Previously replaced the semicolon in the xml entity. DotNetAnalyzers#3802
bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Jun 8, 2024
bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants