Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA1121: UseBuiltInTypeAlias #54

Closed
sharwell opened this issue Nov 18, 2014 · 2 comments · Fixed by #306 or #350
Closed

SA1121: UseBuiltInTypeAlias #54

sharwell opened this issue Nov 18, 2014 · 2 comments · Fixed by #306 or #350
Assignees
@sharwell
Labels
category-readability Readability rules diagnostic easy fixed

Comments

@sharwell
Copy link
Member

http://www.stylecop.com/docs/SA1121.html
@sharwell sharwell self-assigned this Dec 5, 2014
This was referenced Dec 5, 2014
Closed
Closed
sharwell added a commit to sharwell/StyleCopAnalyzers that referenced this issue Dec 5, 2014
@sharwell
Implement diagnostic SA1121 UseBuiltInTypeAlias (fixes DotNetAnalyzer…
74da540 
…s#54)
@sharwell sharwell mentioned this issue Dec 5, 2014
Merged
@sharwell sharwell added the category-readability Readability rules label Jan 8, 2015
@pdelvo
Copy link
Member

pdelvo commented Jan 11, 2015

I unfortunatly started working on this without looking at this issue. So I have a second implementation of this. I will open a pull request for it because it contains a bunch of unit tests which should be usefull with your implementation as well.
I don't know if a code fix is needed for this because visual studio has a refactoring for this.

@pdelvo pdelvo mentioned this issue Jan 11, 2015
Merged
@sharwell
Copy link
Member Author

We can talk about the code fix possibilities in #304.

I propose that we review pull request #306 and merge it, and then you update #350 to just address #303. Does this plan work for you? Also, can you help with the review of #306?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
category-readability Readability rules diagnostic easy fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Type alias diagnostics sharwell/StyleCopAnalyzers
Implemented SA1121 pdelvo/StyleCopAnalyzers
2 participants
@sharwell @pdelvo