Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SQL Filters option on topic subscribtion for Azure Service Bus #1263

Merged

Conversation

giorgilekveishvili-meama
Copy link
Contributor

Added option for custom SQL Filters on topic subscribtion

@giorgilekveishvili-meama
Copy link
Contributor Author

@mviegas Can you review please?

Copy link
Contributor

@mviegas mviegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @giorgilekveishvili-meama ! Would you mind adding a sample for it, for better documentation and a leaner learning curve purpose?

Thank you!

@giorgilekveishvili-meama
Copy link
Contributor Author

I have updated documentation , please check @mviegas

@mviegas
Copy link
Contributor

mviegas commented Jan 19, 2023

Thanks for the doc update @giorgilekveishvili-meama ! If you could add this in the samples as well, we can merge this. 🙏

@giorgilekveishvili-meama
Copy link
Contributor Author

I have added SQLFIlter in Sample @mviegas

Copy link
Contributor

@mviegas mviegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, thanks!

@yang-xiaodong yang-xiaodong merged commit 56df041 into dotnetcore:master Jan 29, 2023
@yang-xiaodong yang-xiaodong changed the title Updated AzureServiceBus Added SQL Filters option on topic subscribtion for Azure Service Bus Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants