New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for kubernetes discovery in dashboard #1362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
At the inception of CAP, Kubernetes was not widely used. We used Consul for dashboard discovery to collect data from other nodes, which greatly streamlined the process of viewing data from different nodes in microservices.
According to feedback from our community, more and more people are using Kubernetes as their deployment environment. We plan to support Kubernetes in our dashboard in the next version. At that time, we will provide a new package DotNetCore.CAP.Dashboard.K8s to continue this support.
To run a pod with Kubernetes discovery, you need to have permissions to access the Kubernetes API server. The required configuration is as follows:
Issue(s) addressed:
Changes:
cap.UseK8sDiscovery()
to support configuring Kubernetes service discovery.cap.UseDiscovery
tocap.UseConsulDiscovery
to avoid ambiguity withcap.UseK8sDiscovery
.service.AddCapDashboardStandalone()
to support running the Dashboard as a standalone pod.Affected components:
cap.UseConsulDiscovery
configuration items.Checklist:
Reviewers: