New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for SNS transport implementation #765

Merged

yang-xiaodong merged 1 commit into dotnetcore:master from roman-bezmen:sns-fix

Jan 14, 2021

Contributor

roman-bezmen commented Jan 13, 2021

This PR contains the fixes for two issues we faced:

If we have more than 100 topics, then AWS SDK returns a token to get the next 100 rows. This was missing.
The first issue wasn't easy to recognize as a message is being marked as succeeded but the message actually wasn't sent in case if the topic is missing.


          Added missing pagination to get all SNS topics. Added marking the mes…

c6bf930

…sage as failed if topic not found.

yang-xiaodong approved these changes

View reviewed changes

Member

yang-xiaodong left a comment

LGTM, Thanks

yang-xiaodong merged commit 83d623c into dotnetcore:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment