Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IriExpression internal constructor public #332

Closed
kal opened this issue Aug 1, 2020 · 1 comment
Closed

Make IriExpression internal constructor public #332

kal opened this issue Aug 1, 2020 · 1 comment
Milestone

Comments

@kal
Copy link
Contributor

kal commented Aug 1, 2020

There is an internal constructor on the IriExpression class that provides a shortcut for creating an IriExpression from a Uri instance. Making this public would allow developers to do new IriExpression(someUri) instead of new IriExpression(new ConstantTerm(new UriNode(null, someUri)))

@kal kal added this to the 2.6.1 milestone Aug 1, 2020
@kal kal added the enhancement label Aug 1, 2020
@kal
Copy link
Contributor Author

kal commented Aug 1, 2020

Note that the URINode constructor is also internal. Should there be some factory method instead of opening up internal constructors? IriExpression.Create(someUri) ?

@kal kal closed this as completed in 2b77611 Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant