Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InAppPyValidationError doesn't return message when error occurs in App Store #2

Closed
axper opened this issue Feb 22, 2018 · 1 comment

Comments

@axper
Copy link

axper commented Feb 22, 2018

When an exception is raised at appstore.py line 86, the App Store error messages declared at the top of the file are not included. Only raw_response parameter is set in the exception object.

I think instead of storing raw_response parameter inside InAppPyValidationError's constructor you should set that value to the message, and set raw_response only in the aforementioned line..

@dotpot
Copy link
Owner

dotpot commented Mar 10, 2018

Thanks! PR's welcome ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants