Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTPS #117

Open
atringham opened this issue May 21, 2019 · 2 comments
Open

Add support for HTTPS #117

atringham opened this issue May 21, 2019 · 2 comments

Comments

@atringham
Copy link

At the moment the scheduler, executor and operations only support using http connections. This should be extended to add support for https.
One way is to add a use_https flag (default False) for each of the respective __init__ and set self.scheme to 'http' or 'https' like the following

if use_https:
  self.scheme = 'https'
else:
  self.scheme = 'http'

And the reference this scheme whenever creating a connection to the maser/agent

if self.scheme == "https":
  conn = HTTPSConnection(...)
else:
  conn = HTTPConnection(...)

A change is also needec to resolve the ip to a fqdn for the master/agent in order for the certificates to be validated

I have a patch that does exactly this which I can make PR from if this is an acceptable approach

@ariesdevil
Copy link
Contributor

PR is welcome.

@KieranMDolan
Copy link

@atringham was this patch still available for a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants