New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meaningful error message if sample splitting was not yet set #117

Open

MalteKurz opened this issue Jul 26, 2021 · 0 comments

Labels

exception handling

Member

MalteKurz commented Jul 26, 2021

Calling

dml_plr_obj = DoubleMLPLR$new(make_plr_CCDDHNR2018(),
                                                        lrn("regr.ranger"), lrn("regr.ranger"),
                                                        draw_sample_splitting = FALSE)
dml_plr_obj$fit()

produces error message

 Error in .__ResamplingCustom__instantiate(self = self, private = private,  : 
  Assertion on 'train_sets' failed: Must be of type 'list', not 'NULL'.

More meaningful would be something in the lines of https://github.com/DoubleML/doubleml-for-py/blob/a574e0afcab0e7cce475925f1344399e75dd4a11/doubleml/double_ml.py#L238-L239.

The text was updated successfully, but these errors were encountered:

MalteKurz added the exception handling label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment