Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minifying the googlemaps.js and dynamicmap.js on cpresources #98

Closed
sander-lameco opened this issue Oct 16, 2023 · 3 comments
Closed

Minifying the googlemaps.js and dynamicmap.js on cpresources #98

sander-lameco opened this issue Oct 16, 2023 · 3 comments
Labels
Feature Request New feature or request

Comments

@sander-lameco
Copy link

Since the files are loaded in the frontend, would it be possible to minify these files?
Or is it something we misconfigured?
We're asking since Lighthouse and SEranking are giving off warnings as the files are not minified.

@lindseydiloreto
Copy link
Collaborator

Thanks for the feature request! I've considered this before... my thought has been to leave it unminified to make the methods more discoverable.

However, there is a fair case for minifying them as well. I'll see if I can provide an option to load minified versions of those files.

Not sure what the ETA is, but I'll post any updates back on this thread.

@lindseydiloreto lindseydiloreto added the Feature Request New feature or request label Oct 16, 2023
@sander-lameco
Copy link
Author

Thanks @lindseydiloreto , no problem, there is no real pressure behind this as it is only a warning but would be nice to be able to minify it in the (near) future.

@lindseydiloreto
Copy link
Collaborator

Great news, this is done! Now available in v4.3.7 👍

If using a PHP config file, there is now an additional setting to minifyJsFiles. Enabling this will serve up the minified versions of those front-end files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants