Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gem 'machinist' because we are using factory_bot instead #176

Closed
lilliealbert opened this issue Oct 18, 2014 · 1 comment · Fixed by #348
Closed

Remove gem 'machinist' because we are using factory_bot instead #176

lilliealbert opened this issue Oct 18, 2014 · 1 comment · Fixed by #348
Labels
dev quality of life Improves the ability or comfort of developers to make changes

Comments

@lilliealbert
Copy link
Member

lilliealbert commented Oct 18, 2014 •
edited by compwron
Loading

We should use only one factory gem. Remove 'machinist'
We are also planning to move from factory_girl (unmaintained) to factory_bot #332
@lilliealbert lilliealbert added the dev quality of life Improves the ability or comfort of developers to make changes label Oct 18, 2014
@compwron compwron changed the title Use one gem for factories Remove gem 'machinist' because we are using factory_bot instead Jun 15, 2019
@compwron
Copy link
Member

This will require changing all the tests that use .make! to use the factory_bot style create(:obj, param: val) instead, then removing the fileblueprints.rb and the line gem 'machinist' from the Gemfile

@compwron compwron mentioned this issue Jun 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev quality of life Improves the ability or comfort of developers to make changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove machinist gem in favor of factory_bot doubleunion/arooo
2 participants
@compwron @lilliealbert