Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit option #6

Closed
cagnulein opened this issue Aug 4, 2020 · 5 comments · Fixed by #13
Closed

Limit option #6

cagnulein opened this issue Aug 4, 2020 · 5 comments · Fixed by #13

Comments

@cagnulein
Copy link

Hi, could you please add the ability to write the LIMIT Bandwith parameter?
I would like to create an automation based on my presence at home (if i'm away, i could set no limit, if i'm home, i could set it to a minimium value...)

Thanks

@doudz
Copy link
Owner

doudz commented Aug 16, 2020

It's possible but needs a bit of refactoring to add a service

@oribafi
Copy link
Collaborator

oribafi commented Apr 21, 2021

I did a rewrite of the integration with that and other features here: https://github.com/oribafi/homeassistant-myjdownloader/tree/rewrite
It's still in early development, so I'm grateful for feedback and anyone willing to test. Thanks for this great integration, which motivated me to learn how to write integrations for HA!

@doudz
Copy link
Owner

doudz commented Apr 21, 2021

Nice !
I'd be happy to test, and fill free to make PR to improve the current integration !

@oribafi oribafi mentioned this issue Apr 21, 2021
5 tasks
@oribafi
Copy link
Collaborator

oribafi commented Apr 21, 2021

Sure, let me know how it works for you! I opened a new issue to track progress on that here: #12

If I remember correctly, wasn't this integration once part of Home Assistant Core? If so, was there a reason for removing it?

@doudz
Copy link
Owner

doudz commented May 21, 2021

Done by @oribafi

@doudz doudz closed this as completed May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants