Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@FilterableField() with nullable:true throws error #20

Closed
johannesschobel opened this issue Feb 18, 2020 · 6 comments
Closed

@FilterableField() with nullable:true throws error #20

johannesschobel opened this issue Feb 18, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@johannesschobel
Copy link
Contributor

Dear @doug-martin ,

a

@FilterableField({
  description: 'firstname of the user',
  nullable: true
})
firstname?: string

throws an error when requesting this field in a query (and if it is actually null).

Changing from @FilterableField() to @Field() removes this issue, however, it is not possible to search by this field any more..

All the best

@doug-martin
Copy link
Owner

Thanks @johannesschobel! Ill start fixing the issues tonight.

Thank you reporting the issues you find I really appreciate it!

@doug-martin doug-martin added the bug Something isn't working label Feb 18, 2020
@doug-martin
Copy link
Owner

Feel free to make a PR on this one also if you want.

@johannesschobel
Copy link
Contributor Author

thank you for creating this awesome package!

@doug-martin
Copy link
Owner

Issued pr #21 to fix this.

@doug-martin
Copy link
Owner

Published! The version with the fix is v0.2.1

@johannesschobel
Copy link
Contributor Author

awesome support.. works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants