Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typegoose): Add typegoose package #846

Merged
merged 24 commits into from
Mar 15, 2021
Merged

Conversation

doug-martin
Copy link
Owner

No description provided.

@llanicm
Copy link
Contributor

llanicm commented Feb 5, 2021

@doug-martin I noticed that a commit I made (1fda249) relies on a specific implementation outwith this package to work, I can show you if you would like to see if it is something you may want to add. This just gives the ability to add single items to array instead of inserting the full array every time. I had to make some custom types to support this which I have in another project that could possibly be added to this or the core package to support this functionality.

@doug-martin doug-martin linked an issue Feb 7, 2021 that may be closed by this pull request
@smolinari
Copy link
Collaborator

@doug-martin @JohnMcInall - Typegoose is about to come out with version 8, where it will be supporting the newer versions of Mongoose and their new types. I've been asked to test it and I'd like to add it to query-typegoose as one of the "tests".

Is that ok with you both? What would your suggestions be to make this happen? Close this PR and start a new one? Or just commit the changes with the new version?

Scott

@doug-martin
Copy link
Owner Author

@smolinari I'm ok with that, as this PR stands its going to be really hard to get it merged because we have diverged mongoose versions. If you want to work against this branch and test it out go for It and we can just merge that one when its ready.

@smolinari
Copy link
Collaborator

smolinari commented Mar 5, 2021

@doug-martin - Just a quick update. Got things going with the upcoming Typegoose 8.0 with the newest Mongoose version. 😁 Now moving to e2e tests.

image

Edit: Cleaned up the deprecation warnings too.

image

Scott

@smolinari
Copy link
Collaborator

smolinari commented Mar 5, 2021

And, now e2e tests are passing. 😁

image

I had to revert class-transformer back to version 0.3.1 as 0.3.2 caused very ugly warnings from Nest.

image

Edit: I'll be waiting for Typegoose to publish their 8.0 beta. Once that is out, I'll PR everything into this branch.

Scott

@doug-martin doug-martin changed the base branch from master to v0.24.0-rc March 10, 2021 05:57
# Conflicts:
#	documentation/docs/introduction/getting-started.md
#	examples/package.json
#	package-lock.json
#	packages/query-mongoose/package.json
…e-support

# Conflicts:
#	examples/package.json
#	package-lock.json
#	packages/query-graphql/package.json
#	packages/query-mongoose/__tests__/services/mongoose-query.service.spec.ts
#	packages/query-mongoose/package.json
#	packages/query-typeorm/package.json
@doug-martin doug-martin marked this pull request as ready for review March 15, 2021 01:49
@doug-martin doug-martin merged commit b228251 into v0.24.0-rc Mar 15, 2021
@doug-martin doug-martin deleted the typegoose-support branch March 15, 2021 01:53
doug-martin added a commit that referenced this pull request Mar 15, 2021
* wip: Typegoose implementation for nestjs-query

* feat: Implementation of the rest of QueryService and Tests

* fix: adding in assemblers that were missed

* docs: Adding documentation for typegoose

* docs: Updating install guides to include Typegoose

* docs: Updating the getting-started documentation

* feat: adding the ability to add and remove items from an array using a specific UpdateArray Input type.

* feat: adds typegoose e2e testing

* tests: fixes failing typegoose unit tests

* chore: remove commented code

* feat(typegoose): Getting tests passing

* Initial work

* feat(typegoose): WIP

* feat(typegoose): WIP

* feat(typegoose): WIP

* feat(typegoose): small corrections

* chore(): Update typegoose example to use QueryOptions decorator

* chore(): Fix linting issues

Co-authored-by: John McInall <johnmcinall@odro.co.uk>
Co-authored-by: John McInall <johnmcinall@pop-os.localdomain>
Co-authored-by: Scott <scott.molinari@adduco.de>
Co-authored-by: John McInall <johnmcinall@gmail.com>
doug-martin added a commit that referenced this pull request Mar 15, 2021
* wip: Typegoose implementation for nestjs-query

* feat: Implementation of the rest of QueryService and Tests

* fix: adding in assemblers that were missed

* docs: Adding documentation for typegoose

* docs: Updating install guides to include Typegoose

* docs: Updating the getting-started documentation

* feat: adding the ability to add and remove items from an array using a specific UpdateArray Input type.

* feat: adds typegoose e2e testing

* tests: fixes failing typegoose unit tests

* chore: remove commented code

* feat(typegoose): Getting tests passing

* Initial work

* feat(typegoose): WIP

* feat(typegoose): WIP

* feat(typegoose): WIP

* feat(typegoose): small corrections

* chore(): Update typegoose example to use QueryOptions decorator

* chore(): Fix linting issues

Co-authored-by: John McInall <johnmcinall@odro.co.uk>
Co-authored-by: John McInall <johnmcinall@pop-os.localdomain>
Co-authored-by: Scott <scott.molinari@adduco.de>
Co-authored-by: John McInall <johnmcinall@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing Typegoose possible
3 participants