Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoinbasePro.WebSocket.Models.Response.Match missing fields #198

Closed
bthtrade opened this issue Apr 16, 2019 · 2 comments · Fixed by #199
Closed

CoinbasePro.WebSocket.Models.Response.Match missing fields #198

bthtrade opened this issue Apr 16, 2019 · 2 comments · Fixed by #199

Comments

@bthtrade
Copy link

When subscribed to the Match messages, being authenticated, API Reference says:

If authenticated, and you were the taker, the message would also have the following fields:
taker_user_id: "5844eceecf7e803e259d0365",
user_id: "5844eceecf7e803e259d0365",
taker_profile_id: "765d1549-9660-4be2-97d4-fa2d65fa3352",
profile_id: "765d1549-9660-4be2-97d4-fa2d65fa3352"

Those fields are not present in the CoinbasePro.WebSocket.Models.Response.Match class.
Would it be possible to add those?

@dougdellolio
Copy link
Owner

dougdellolio commented Apr 16, 2019

added in #199. thanks

@nicbavetta
Copy link
Contributor

nicbavetta commented Feb 6, 2021

This model is currently out of date. See here.

If the user is the maker, the following data will be included in the response:

maker_user_id: "5f8a07f17b7a102330be40a3",
user_id: "5f8a07f17b7a102330be40a3",
maker_profile_id: "7aa6b75c-0ff1-11eb-adc1-0242ac120002",
profile_id: "7aa6b75c-0ff1-11eb-adc1-0242ac120002",
maker_fee_rate: "0.001"

If the user is the taker, the following data will be included in the response:

taker_user_id: "5844eceecf7e803e259d0365",
user_id: "5844eceecf7e803e259d0365",
taker_profile_id: "765d1549-9660-4be2-97d4-fa2d65fa3352",
profile_id: "765d1549-9660-4be2-97d4-fa2d65fa3352",
taker_fee_rate: "0.005"

I have submitted a pull request after adding the missing properties:

  • maker_user_id
  • maker_profile_id
  • maker_fee_rate
  • taker_fee_rate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants