Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

herbgobbler doesn't move confirm: into the translation file #23

Open
ceigel opened this issue Dec 1, 2014 · 0 comments
Open

herbgobbler doesn't move confirm: into the translation file #23

ceigel opened this issue Dec 1, 2014 · 0 comments

Comments

@ceigel
Copy link

ceigel commented Dec 1, 2014

I have a link_to with a confirm: key added to it. Herbgobbler transfers the text of the link, but not the confirm. It would be great if it would move the confirm to the translation files, as well

Before gobble i18n -a .
-<%= link_to '| Leave course', @course_subscription, method: :delete, remote:true, confirm: "All your progress will be lost, are you sure you want to leave course?" %>

After.
+<%= link_to (t '.leave_course'), @course_subscription, method: :delete, remote:true, confirm: "All your progress will be lost, are you sure you want to leave course?" %>

It would be great if the confirm text would be added as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant