Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradient at boundary not enforced for viscous flows #240

Open
jbrillon opened this issue Sep 20, 2023 · 1 comment · May be fixed by #199
Open

Gradient at boundary not enforced for viscous flows #240

jbrillon opened this issue Sep 20, 2023 · 1 comment · May be fixed by #199
Assignees
@jbrillon

Comments

@jbrillon
Copy link
Collaborator

Currently, the gradient at the physical boundary (soln_grad_ext) set by boundary_face_values is not being enforced; as it is being set to the interior value (soln_grad_int) in all cases inside evaluate_auxiliary_flux.

To fix it, we must pass on_boundary flag to PhysicsBase's dissipative_flux and modify the dissipative flux accordingly; the fix take effect in assemble_boundary_term
@jbrillon jbrillon self-assigned this Sep 20, 2023
@jbrillon
Copy link
Collaborator Author

will be fixed by jbrillon#11 once PR #199 goes through

@jbrillon jbrillon linked a pull request Sep 21, 2023 that will close this issue
Turbulent channel flow #199
Draft
@jbrillon jbrillon linked a pull request Sep 7, 2023 that will close this issue
Draft
@cpethrick cpethrick mentioned this issue Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbrillon jbrillon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Turbulent channel flow jbrillon/PHiLiP
1 participant
@jbrillon