-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack trace api differences when in strict mode causing TypeErrors #17
Comments
I'll take a look into this. Any suggestions are welcome :) |
Actually, I assume this just make a |
Not super familiar with the call stack api or your normalization stuff, figured I'd capture the issue before diving in to your caller resolution stuff.
|
That's fine. Really, I just need a definition of what "causing problems" from your title means. Are there Errors being thrown? If so what are they? If not, what's happening? |
Hah. Sorry. Those are the only two TypeErrors I've come across so far. |
Cool. This is officially a bug at this point :) |
I'll write a test case for realizing a |
'use strict';
var dep = require('depd')('dep');
var inc = dep.function(function deprecated() {});
inc.apply(inc);
|
Nice. I've found a bunch of issues playing with it already :) Hopefully I want to get a new patch version out tonight for this issue :D |
Awesome! Thanks for your attention to this, Doug. 😀 |
No problem at all! The |
👍 looking forward to seeing what you come up with. |
haha. and lol, this isn't super fun; seems V8 didn't completely think of all the different methods in their error API when they implemented |
I think I have it mostly working so far :) |
The worse part is that from those API docs:
This is true... but not for Node.js < 0.12, which throw on |
Hah. Sorry for opening up this can of worms. 😉 |
lol. It's no problem. We'll get this fixed :D! |
Basically it seems like this part of V8 that is in Node.js 0.10 is buggy, lol |
Ok, so hopefully it's all fixed on |
Tried in my application and in my test cases. Everything works! Thanks, Doug! |
Sweet :D I plan to publish tonight (US Eastern time) as version 1.0.1 |
Sounds good! Thanks again! |
I see it was released. Thanks again, Doug! |
No problem! Sorry, I got too busy last night to make the release :( |
Haha. Not a problem at all. I appreciate it! |
Can be realized by setting strict mode in
test/fixtures/my-lib
.From the API docs:
Failing test:
The text was updated successfully, but these errors were encountered: